-
Notifications
You must be signed in to change notification settings - Fork 764
migration for inactive user purge #6676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smithellis
wants to merge
4
commits into
mozilla:main
Choose a base branch
from
smithellis:delete-expired-users-via-pipeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
161 changes: 161 additions & 0 deletions
161
kitsune/users/migrations/0035_batch_delete_inactive_users.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,161 @@ | ||
from datetime import timedelta | ||
import time | ||
|
||
from django.db import migrations | ||
from django.db.models import Q | ||
from django.utils import timezone | ||
from django.contrib.auth import get_user_model | ||
|
||
from kitsune.users.utils import delete_user_pipeline | ||
|
||
|
||
def delete_inactive_users(apps, schema_editor): | ||
""" | ||
Delete users who haven't logged in for over three years. | ||
""" | ||
User = get_user_model() | ||
|
||
has_content_criteria = ( | ||
Q(answer_votes__isnull=False) | ||
| Q(answers__isnull=False) | ||
| Q(award_creator__isnull=False) | ||
| Q(badge__isnull=False) | ||
| Q(created_revisions__isnull=False) | ||
| Q(gallery_images__isnull=False) | ||
| Q(gallery_videos__isnull=False) | ||
| Q(outbox__isnull=False) | ||
| Q(poll_votes__isnull=False) | ||
| Q(post__isnull=False) | ||
| Q(question_votes__isnull=False) | ||
| Q(questions__isnull=False) | ||
| Q(readied_for_l10n_revisions__isnull=False) | ||
| Q(reviewed_revisions__isnull=False) | ||
| Q(thread__isnull=False) | ||
| Q(wiki_post_set__isnull=False) | ||
| Q(wiki_thread_set__isnull=False) | ||
| Q(locales_leader__isnull=False) | ||
| Q(locales_reviewer__isnull=False) | ||
| Q(locales_editor__isnull=False) | ||
| Q(wiki_contributions__isnull=False) | ||
) | ||
|
||
cutoff_date = timezone.now() - timedelta(days=3*365) | ||
|
||
# Get users with content (need pipeline deletion) | ||
users_with_content = User.objects.filter( | ||
last_login__lt=cutoff_date | ||
).filter(has_content_criteria) | ||
|
||
# Get users without content (can be bulk deleted) | ||
users_without_content = User.objects.filter( | ||
last_login__lt=cutoff_date | ||
).exclude(has_content_criteria) | ||
|
||
total_users = users_with_content.count() + users_without_content.count() | ||
|
||
if total_users == 0: | ||
print("No inactive users to delete") | ||
return | ||
|
||
print(f"Starting deletion of {total_users:,} inactive users") | ||
print(f"Users with content: {users_with_content.count():,}") | ||
print(f"Users without content: {users_without_content.count():,}") | ||
start_time = time.time() | ||
processed_count = 0 | ||
pipeline_count = 0 | ||
direct_count = 0 | ||
|
||
# Process users with content using pipeline | ||
print("Processing users with content...") | ||
for user in users_with_content.iterator(chunk_size=1000): | ||
try: | ||
delete_user_pipeline(user) | ||
pipeline_count += 1 | ||
except Exception as e: | ||
print(f"Error deleting user {user.id}: {e}") | ||
|
||
processed_count += 1 | ||
|
||
# Progress reporting every 1000 users | ||
if processed_count % 1000 == 0: | ||
elapsed_time = time.time() - start_time | ||
progress_pct = processed_count / total_users * 100 | ||
avg_time = elapsed_time / processed_count | ||
remaining_time = (total_users - processed_count) * avg_time | ||
current_rate = processed_count / elapsed_time * 60 | ||
|
||
print( | ||
f"Progress: {processed_count:,}/{total_users:,} ({progress_pct:.1f}%) | " | ||
f"Pipeline: {pipeline_count:,} | Direct: {direct_count:,} | " | ||
f"Rate: {current_rate:.1f} users/min | " | ||
f"Remaining: {timedelta(seconds=int(remaining_time))}" | ||
) | ||
|
||
# Batch delete users without content | ||
print("Processing users without content...") | ||
batch_size = 1000 | ||
users_no_content_batch = [] | ||
|
||
def bulk_delete_no_content_users(): | ||
nonlocal direct_count | ||
if users_no_content_batch: | ||
try: | ||
User._base_manager.filter(id__in=users_no_content_batch).delete() | ||
direct_count += len(users_no_content_batch) | ||
users_no_content_batch.clear() | ||
except Exception as e: | ||
print(f"Error batch deleting users: {e}") | ||
|
||
for user in users_without_content.iterator(chunk_size=1000): | ||
users_no_content_batch.append(user.id) | ||
|
||
# Bulk delete when batch is full | ||
if len(users_no_content_batch) >= batch_size: | ||
bulk_delete_no_content_users() | ||
|
||
processed_count += 1 | ||
|
||
# Progress reporting every 1000 users | ||
if processed_count % 1000 == 0: | ||
elapsed_time = time.time() - start_time | ||
progress_pct = processed_count / total_users * 100 | ||
avg_time = elapsed_time / processed_count | ||
remaining_time = (total_users - processed_count) * avg_time | ||
current_rate = processed_count / elapsed_time * 60 | ||
|
||
print( | ||
f"Progress: {processed_count:,}/{total_users:,} ({progress_pct:.1f}%) | " | ||
f"Pipeline: {pipeline_count:,} | Direct: {direct_count:,} | " | ||
f"Rate: {current_rate:.1f} users/min | " | ||
f"Remaining: {timedelta(seconds=int(remaining_time))}" | ||
) | ||
|
||
# Delete any remaining users without content | ||
bulk_delete_no_content_users() | ||
|
||
total_time = time.time() - start_time | ||
print( | ||
f"Deletion Complete: {processed_count:,} users deleted " | ||
f"({pipeline_count:,} pipeline, {direct_count:,} direct) " | ||
f"in {timedelta(seconds=int(total_time))}" | ||
) | ||
|
||
|
||
def reverse_migration(apps, schema_editor): | ||
""" | ||
No reverse migration possible since deletion cannot be undone | ||
""" | ||
pass | ||
|
||
|
||
class Migration(migrations.Migration): | ||
dependencies = [ | ||
("users", "0034_batch_delete_non_migrated_users"), | ||
] | ||
|
||
operations = [ | ||
migrations.RunPython( | ||
delete_inactive_users, | ||
reverse_migration, | ||
), | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be
User = apps.get_model("auth", "User")
in migrations similar to the previous one (0034)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary because the
delete_user_pipeline
function needs an actual User instance vs. a historical model.